Convert Rails tests to RSpec #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
commented
Oct 25, 2019
| @@ -312,7 +312,6 @@ elsif Gem::Version.new('2.2.0') <= Gem::Version.new(RUBY_VERSION) \ | |||
| appraise 'rails5-postgres-redis-activesupport' do | |||
| gem 'rails', '~> 5.2.1' | |||
| gem 'pg', '< 1.0', platform: :ruby | |||
| gem 'redis-rails' | |||
There was a problem hiding this comment.
redis-rails functionality is now supported out of the box by Rails, since v5.2, effectively deprecating this gem since then: https://github.com/redis-store/redis-rails#a-quick-note-about-rails-52
marcotc
commented
Oct 25, 2019
| @@ -12,7 +12,7 @@ desc 'Run RSpec' | |||
| # rubocop:disable Metrics/BlockLength | |||
| namespace :spec do | |||
| task all: [:main, | |||
| :rails, :railsredis, :railssidekiq, :railsactivejob, | |||
| :rails, :railsredis, :railsactivejob, | |||
There was a problem hiding this comment.
:railssidekiq had one file with no tests.
All relevant Rails+Sidekiq related tests have been merged with the :railsactivejob task.
delner
approved these changes
Dec 10, 2019
| end | ||
| end | ||
|
|
||
| xcontext '#write' do |
There was a problem hiding this comment.
Let's convert any xcontext to context.
|
|
||
| # Re-configure the tracer with a new test writer | ||
| # since priority sampling will wipe out the old test writer. | ||
| unless @writer.is_a?(FauxWriter) |
There was a problem hiding this comment.
This part of the code is super hairy; we'd like to get rid of it, probably with #879.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts most Rails tests from minitest to RSpec.
Also, added a few enhancements to
tracer_helpers.rbto allow for easier assertions around tracer and span instances.Given this PR is already sizeable, I chose to defer the last couple large minitest files, to allow for easier reviewing.