Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit GitHub dependency from Gemfile #847

Merged
merged 11 commits into from
Dec 14, 2020
Merged

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Oct 28, 2019

I noticed that every time I ran bundle install in this repository, Bundler would take a second or two to fetch this gem:

$ bundle install
Fetching https://github.com/nixme/pry-nav.git

It seems like we introduced this GitHub dependency due to an incompatibility between our pry, debugger pry-nav, and the version of pry we used at the time.

Fast-forward a year, a new version pry-nav has been released that supports pry version < 13.

I've also unlocked the patch version from pry-stack_explorer, as there was a patch release since we last locked it.

The new versions are compatible with all our supported versions of Ruby.

@marcotc marcotc requested a review from a team October 28, 2019 22:18
@marcotc marcotc self-assigned this Oct 28, 2019
@marcotc marcotc added the dev/testing Involves testing processes (e.g. RSpec) label Oct 28, 2019
Appraisals Outdated Show resolved Hide resolved
@delner delner added this to In review in Active work Nov 21, 2019
@marcotc
Copy link
Member Author

marcotc commented Dec 20, 2019

Rails CI issue has been fixed. PR is ready for review.

Copy link
Contributor

@ericmustin ericmustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pry/pry-nav stuff lgtm, small question: will pry-stack_explorer work with jruby, and, is that required? I noticed this issue on their repo from 2017...should we be disabling on jruby?

pry/pry-stack_explorer#14 (comment)

@marcotc
Copy link
Member Author

marcotc commented Aug 4, 2020

That's a good point @ericmustin. Now that JRuby support is fully merged I tried the pry development experience again, and I noticed that pry-stack_explorer installs but doesn't work correctly. I couldn't find any alternatives, so I just removed it from installing with JRuby for the time being.

@marcotc marcotc requested a review from ericmustin August 4, 2020 21:34
@marcotc
Copy link
Member Author

marcotc commented Dec 11, 2020

Build will fail because of Rails 6.1.

Copy link
Contributor

@ericmustin ericmustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcotc marcotc merged commit 52e5369 into master Dec 14, 2020
Active work automation moved this from In review to Merged & awaiting release Dec 14, 2020
@marcotc marcotc deleted the test/update-pry branch December 14, 2020 20:23
@github-actions github-actions bot added this to the 0.44.0 milestone Dec 14, 2020
@delner delner moved this from Merged & awaiting release to Released in Active work Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
Active work
  
Released
Development

Successfully merging this pull request may close these issues.

None yet

2 participants