-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove explicit GitHub dependency from Gemfile #847
Conversation
Rails CI issue has been fixed. PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pry/pry-nav stuff lgtm, small question: will pry-stack_explorer work with jruby, and, is that required? I noticed this issue on their repo from 2017...should we be disabling on jruby?
That's a good point @ericmustin. Now that JRuby support is fully merged I tried the |
Build will fail because of Rails 6.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I noticed that every time I ran
bundle install
in this repository, Bundler would take a second or two to fetch this gem:It seems like we introduced this GitHub dependency due to an incompatibility between our
pry
, debuggerpry-nav
, and the version ofpry
we used at the time.Fast-forward a year, a new version
pry-nav
has been released that supportspry
version< 13
.I've also unlocked the patch version from
pry-stack_explorer
, as there was a patch release since we last locked it.The new versions are compatible with all our supported versions of Ruby.