Extract logging from Datadog::Tracer to Datadog::Logger #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
core
brettlangdon
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging functions in the
Tracerclass are global-level and totally independent of the other functions within the tracer. Given this, and tracer doesn't need to be responsible for logging, let's extract logging fromTracerto our existingDatadog::Logger.Major benefit of doing so is that there are many components that depend on logging functions, but do not need the
Traceritself. Often times doingrequire 'ddtrace/tracerto get these functions results in a circular reference. Extracting this dependency prevents this kind of error from happening.