Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource for Rails template spans #881

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Add resource for Rails template spans #881

merged 1 commit into from
Dec 16, 2019

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Dec 10, 2019

Fixes #855

Sets span.resource to the template name for rails.render_template and rails.render_partial spans, if the template name is available.

We were already setting tags for template name and layout, but not span resource name.

In this example you see posts/index.html.erb as the resource name:
Screen Shot 2019-12-10 at 5 17 23 PM

@marcotc marcotc added integrations Involves tracing integrations feature Involves a product feature labels Dec 10, 2019
@marcotc marcotc requested a review from a team December 10, 2019 22:24
@marcotc marcotc self-assigned this Dec 10, 2019
delner
delner approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple but big improvement. Thanks @marcotc and @djmb for suggesting this! 🎉

@marcotc marcotc merged commit ba583b5 into master Dec 16, 2019
@marcotc marcotc added this to Merged & awaiting release in Active work via automation Dec 16, 2019
@marcotc marcotc deleted the feat/rails-template-resource branch December 16, 2019 22:17
@delner delner mentioned this pull request Dec 17, 2019
Closed
@marcotc marcotc added this to the 0.31.0 milestone Jan 7, 2020
@delner delner moved this from Merged & awaiting release to Released in Active work Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delner delner delner approved these changes

Assignees

@marcotc marcotc

Labels
feature Involves a product feature integrations Involves tracing integrations
Projects
Active work
  
Released
Milestone
0.31.0
Development

Successfully merging this pull request may close these issues.

Set template/partial name as the resource for rails.render_template and rails.render_partial
2 participants
@marcotc @delner