Only associate spans with runtime metrics if enabled #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
force-pushed
the
fix/runtime_metrics_default_association
branch
from
24cfdda
to
e6f32b3
Compare
delner
force-pushed
the
fix/runtime_metrics_default_association
branch
from
e6f32b3
to
638aa0a
Compare
delner
added a commit
that referenced
this pull request
Dec 30, 2019
…ciation Only associate spans with runtime metrics if enabled
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trace writer associates spans with runtime metrics so the metrics are assigned to the correct services. However, it was not checking if runtime metrics was enabled, meaning it would accumulate service names regardless of whether runtime metrics was on or off.
This pull request changes the writer behavior to respect the runtime metrics enabled flag when associating with traces.