The net/http integration doesn't annotate requests that raise exceptions

[djmb]

If a net/http request raises an exception (e.g. Net::OpenTimeout), then the span is not annotated with tags from the request.

See:

dd-trace-rb/lib/ddtrace/contrib/http/instrumentation.rb

Line 55 in ba583b5

annotate_span!(span, req, response)

annotate_span! is called after the request completes and will be missed if an exception is raised. Since some of the annotations rely on having a response it should maybe be split into two parts, one called before the request is issued and one after.

[marcotc]

Thank you @djmb for your report.

I was able to create a test case to reproduce the issue.

We'll follow up if we need more information, but I believe the problem is clearly defined here.

[delner]

Makes sense to me, thanks for the report @djmb!

[marcotc]

👋 @djmb, we've just released v0.32.0 that includes a fix for this issue.

Let us know if the problem still persists after these changes.