Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Redis version for Rails >= 5.2 cache #890

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Set Redis version for Rails >= 5.2 cache #890

merged 1 commit into from
Dec 20, 2019

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Dec 18, 2019

We are currently not requiring the minimum version of redis required by Rails >= 5.2 to use the default redis_cache_store implementation.

This allows bundler to install redis ~> 3 in CI sometimes, causing random test breakage.

This dependency is not a transitive requirement for Rails because using redis for caching is not mandatory.

@marcotc marcotc added the dev/testing Involves testing processes (e.g. RSpec) label Dec 18, 2019
@marcotc marcotc requested a review from a team December 18, 2019 21:35
@marcotc marcotc self-assigned this Dec 18, 2019
@marcotc marcotc mentioned this pull request Dec 18, 2019
Merged
delner
delner approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcotc marcotc merged commit 6952818 into master Dec 20, 2019
@marcotc marcotc deleted the test/minimum-redis-rails-5_2 branch December 20, 2019 18:50
delner pushed a commit that referenced this pull request Dec 30, 2019
@marcotc @delner
Set Redis version for Rails >= 5.2 cache (#890)
933153f
@delner delner mentioned this pull request Dec 30, 2019
Merged
@marcotc marcotc added this to the 0.31.0 milestone Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delner delner delner approved these changes

Assignees

@marcotc marcotc

Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Milestone
0.31.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcotc @delner