Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following wait loop does not exist as one would expect:
The
break
statement is actually breaking out of#synchronize
, not#times
, meaning this test always runs to its maximum time of around 11s.This PR replaces this loop with our helper method
try_wait_until
. I also removed the mutex around the instance variable assignment verification, as instance variable assignment is an atomic VM operation.This is the slowest single test in our test suite currently.