Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining usages of Datadog::Tracer.log #912

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Fix remaining usages of Datadog::Tracer.log #912

merged 1 commit into from
Jan 8, 2020

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Jan 8, 2020

When the extraction of Datadog::Tracer.log to Datadog::Logger.log happened in #880, #824 was still in progress.

Given that this changed affected #824 in non-critical error paths that are not common, they were not exercised by CI during brach rebasing.

This PR migrates all remaining reference to log methods in Datadog::Tracer to use Datadog::Logger instead.

@marcotc marcotc added the bug Involves a bug label Jan 8, 2020
@marcotc marcotc requested a review from a team January 8, 2020 21:07
@marcotc marcotc self-assigned this Jan 8, 2020
delner
delner approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should be the remaining references. We just have to make sure any old PRs have the same change. Thanks for the fix, @marcotc!

@marcotc marcotc merged commit 5602793 into master Jan 8, 2020
@marcotc marcotc deleted the fix/move-log-to-logger branch January 8, 2020 21:19
@marcotc marcotc added this to the 0.32.0 milestone Jan 8, 2020
marcotc added a commit that referenced this pull request Jan 15, 2020
@marcotc
Fix remaining usages of Datadog::Tracer.log (#912)
799d08a
@marcotc marcotc mentioned this pull request Jan 15, 2020
Merged
@marcotc marcotc modified the milestones: 0.32.0, 0.31.1 Jan 16, 2020
@ericmustin ericmustin mentioned this pull request Feb 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delner delner delner approved these changes

Assignees

@marcotc marcotc

Labels
bug Involves a bug
Projects
None yet
Milestone
0.31.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcotc @delner