Lock Rack version due to Grape incompatibility #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
added
integrations
|
I suggest working on a fix in Grape rather than hiding this. Maybe try a PR for the fix there? |
|
@dblock We will try to fix the bug at the source if we can; this change is just to unblock our CI pipeline, which tests Grape and our instrumentation of it. |
marcotc
added a commit
that referenced
this pull request
Jan 15, 2020
Merged
delner
added a commit
that referenced
this pull request
Feb 27, 2020
delner
added a commit
that referenced
this pull request
Feb 27, 2020
delner
added a commit
that referenced
this pull request
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly released version of Rack,
2.1.0, is incompatible with the latest version of Grape: ruby-grape/grape#1966This PR locks Rack to
< 2.1.0until Grape updates the issue with further instructions.This unblocks our CI builds.