Update class-based GraphQL schema #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
added
integrations
delner
pushed a commit
that referenced
this pull request
Feb 27, 2020
delner
pushed a commit
that referenced
this pull request
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CI failure
The GraphQL gem has deprecated
.define-style schema definition.Documentation has been updated to provide configuration examples using a class-based schema definition, while also keeping the original examples as define-style is still supported.
In our test suite, were mixing class-based and .define-style schema definition, which triggered issues with the release of
graphql 1.10.This PR expands our CI test fixture by creating the whole schema definition with both versions (class and .define styles).