Ensure Datadog::Statsd is loaded during test #929
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this flaky
metrics_spec.rb
test: https://app.circleci.com/jobs/github/DataDog/dd-trace-rb/52268The failure happens because a few tests reference
Datadog::Statsd
in theirbefore
steps without ensuring that it has been loaded:dd-trace-rb/spec/ddtrace/metrics_spec.rb
Line 166 in 97e8e0d
More often then not,
Datadog::Statsd
gets dynamically loaded bymetrics.rb
dd-trace-rb/lib/ddtrace/metrics.rb
Line 43 in 97e8e0d
and tests run fine, but we shouldn't depend on the side-effects of other tests for a correct test run.
Because I explicitly
require 'datadog/statsd'
in the test file, I've added a new test to ensure that our code that dynamically loadsDatadog::Statsd
still works.