Add #add to configuration resolver #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
integrations
delner
force-pushed
the
refactor/configuration_resolver
branch
from
b8b40c6
to
05e68a6
Compare
mberlanda
reviewed
Feb 5, 2020
| @@ -9,6 +9,16 @@ module Configuration | |||
| class Resolver < Contrib::Configuration::Resolver | |||
| def initialize(configurations = nil) | |||
| @configurations = configurations | |||
| @well_known_keys = {} | |||
There was a problem hiding this comment.
This may be renamed to @resolved_keys.
Would you see any interest in using concurrent ruby data structures here?
There was a problem hiding this comment.
I like that name; I'll update, thanks!
As much as we'd like to, we can't use any libraries (including concurrent-ruby) as they may conflict with user's own copies of these gems. However if you have a custom resolver in your own application or integration, you're welcome to use it.
delner
force-pushed
the
refactor/configuration_resolver
branch
from
05e68a6
to
4eb3ec8
Compare
|
Did some refactoring to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support the expansion of "multiplexing" (having multiple configurations per integration) and its applications in #882 and #861/#937, this pull request refactors the
Datadog::Contrib::Configuration::Resolverand adds an#addfunction to it, to allow for certain use cases to operate more efficiently. See linked issues/PRs for example cases.This was originally a change introduced in #882 by @stormsilver, but extracted it out as a base for other PRs as well.