Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidekiq integration broke with Rails 6.0.2 #943

Closed
pj0tr opened this issue Feb 7, 2020 · 8 comments · Fixed by #947
Closed

Sidekiq integration broke with Rails 6.0.2 #943

pj0tr opened this issue Feb 7, 2020 · 8 comments · Fixed by #947
Assignees
Labels
bug Involves a bug community Was opened by a community member integrations Involves tracing integrations
Projects
Milestone

Comments

@pj0tr
Copy link

pj0tr commented Feb 7, 2020

rails/rails@0e64348 changed job['wrapped'] to contain a class instead of the class name as a string, causing these types of errors whenever a trace contains a Sidekiq job.

ERROR -- ddtrace: [ddtrace] (/usr/local/bundle/gems/ddtrace-0.32.0/lib/ddtrace/transport/http/client.rb:46:in `rescue in send_request') Internal error during HTTP transport request. Cause: undefined method `to_msgpack' for Searchkick::ReindexV2Job:Class Location: /usr/local/bundle/gems/msgpack-1.3.1/lib/msgpack.rb:46:in `write'

@delner delner self-assigned this Feb 7, 2020
@delner delner added bug Involves a bug community Was opened by a community member integrations Involves tracing integrations labels Feb 7, 2020
@delner
Copy link
Contributor

delner commented Feb 7, 2020

Ah okay, this makes sense, we'll get a bugfix out for this. Thanks @pj0tr!

@delner
Copy link
Contributor

delner commented Feb 13, 2020

Opened #947 for this, but not sure if it fixes the problems since I've been unable to reproduce it. Can you try and verify this @pj0tr ?

@mattmcf
Copy link

mattmcf commented Feb 24, 2020

+1 We're also running into the same issue. @delner I'd be happy to help reproduce. I'm not quite sure how to build the gem at this sha and use it in my local environment though. Any guidance there?

@delner
Copy link
Contributor

delner commented Feb 25, 2020

@mattmcf You have two options to use the current PR #947:

  1. Use the branch directly gem 'ddtrace', git: 'https://github.com/DataDog/dd-trace-rb', branch: 'fix/sidekiq_with_rails_6.0.2'
  2. Use the preview build (okay for temporary use but not long term):
source 'http://gems.datadoghq.com/prerelease' do
  gem 'ddtrace', '0.32.0.fix.sidekiq.with.rails.6.0.2.56001'
end

@mattmcf
Copy link

mattmcf commented Feb 25, 2020

@delner Thanks! That worked great.

I can confirm that this fix addressed the issue for me. I'm now seeing spans emitted when I wasn't before.

@delner
Copy link
Contributor

delner commented Feb 25, 2020

Okay, wonderful, thanks for the confirmation @mattmcf! We'll get this merged and released.

@mattmcf
Copy link

mattmcf commented Feb 27, 2020

@delner Do you know when you'll cut the release?

@delner
Copy link
Contributor

delner commented Feb 28, 2020

Likely next week.

@delner delner added this to the 0.33.0 milestone Mar 5, 2020
@delner delner added this to Resolved/Closed in Active work Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Involves a bug community Was opened by a community member integrations Involves tracing integrations
Projects
Active work
  
Resolved/Closed
Development

Successfully merging a pull request may close this issue.

3 participants