Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Update: Fix Spelling of Elasticsearch #948

Merged
merged 2 commits into from
Feb 18, 2020

Conversation

mstruve
Copy link
Contributor

@mstruve mstruve commented Feb 17, 2020

Hi!

I noticed that your docs had Elasticsearch spelled incorrectly so I went ahead and fixed it. Elasticsearch is actually a single word and "search" is not capitalized.

Please let me know if there is anything else you need for this change or if you have any questions! Thanks!

@mstruve mstruve requested a review from a team February 17, 2020 20:08
@andygeorge
Copy link

https://twitter.com/RealAndyGeorge/status/1189586418181509120

Copy link
Contributor

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straightforward. One minor issue with the links but otherwise seems fine to me.

docs/GettingStarted.md Outdated Show resolved Hide resolved
docs/GettingStarted.md Outdated Show resolved Hide resolved
@mstruve mstruve requested a review from delner February 18, 2020 19:45
Copy link
Contributor

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good; don't worry about the CI build there (flaky test.)

Thanks for the contribution @mstruve!

@delner delner merged commit 3b8bb64 into DataDog:master Feb 18, 2020
@delner delner added community Was opened by a community member docs Involves documentation labels Mar 5, 2020
@delner delner added this to the 0.33.0 milestone Mar 5, 2020
@mstruve mstruve deleted the patch-1 branch March 5, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Was opened by a community member docs Involves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants