Fix RuleSampler forwarding #update to sampler without #update #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
bug
|
@BabyGroot I think this should fix your issue... can you try out this PR and confirm it fixes the bug you were seeing? |
delner
force-pushed
the
fix/rule_sampler_update_error
branch
from
9589203
to
d717ed3
Compare
Thanks so much for the PR! 🙏 Will test it ASAP, just a bit swamped with ops at the moment... |
|
I have tested in staging and don't see that log error happening. LGTM, thank you! |
delner
force-pushed
the
fix/rule_sampler_update_error
branch
from
d717ed3
to
7b43380
Compare
marcotc
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #949
Normally, the
RuleSamplerhas a default sampler ofRateByServiceSamplerwhich responds to#update. When theRuleSampleris configured with a default sample rate, it sets aRateSampleras its default sampler, which does not respond to#update.Thus when the transport receives priority sampling rates and attempts to update the sampler, it calls
RuleSamplerwithupdateand attempts to forward toRateSamplerwhich raises aNoMethodError.In this pull request, we check if the default sampler responds to
#updatebefore forwarding. If it does not, returnfalseinstead.