Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset and old values for options #957

Merged
merged 2 commits into from
Feb 26, 2020
Merged

Conversation

delner
Copy link
Contributor

@delner delner commented Feb 24, 2020

This pull request introduces a couple of small features to configuration options

  • Adds reset_option which allows individual options to be reset without resetting the entire configuration.
  • Adds the old value to setter and on_set args so the blocks can use them
    e.g. setter { |value, old_value| ... }

@delner delner added core Involves Datadog core libraries feature Involves a product feature labels Feb 24, 2020
@delner delner requested review from marcotc and a team February 24, 2020 18:58
@delner delner self-assigned this Feb 24, 2020
brettlangdon
brettlangdon previously approved these changes Feb 24, 2020
marcotc
marcotc previously approved these changes Feb 24, 2020
@delner delner dismissed stale reviews from marcotc and brettlangdon via 20de1f6 February 24, 2020 20:54
@delner delner force-pushed the feature/option_old_value_and_reset branch from a47f09e to 20de1f6 Compare February 24, 2020 20:54
@delner delner added this to In review in Active work Feb 24, 2020
@delner delner merged commit 2a0b941 into master Feb 26, 2020
Active work automation moved this from In review to Merged & awaiting release Feb 26, 2020
@delner delner deleted the feature/option_old_value_and_reset branch February 26, 2020 17:59
@delner delner added this to the 0.33.0 milestone Mar 5, 2020
@delner delner moved this from Merged & awaiting release to Released in Active work Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries feature Involves a product feature
Projects
Active work
  
Released
Development

Successfully merging this pull request may close these issues.

None yet

3 participants