Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add measured metric tag #974

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Add measured metric tag #974

merged 2 commits into from
Mar 18, 2020

Conversation

delner
Copy link
Contributor

@delner delner commented Mar 17, 2020

To support better service statistics, this pull request adds the _dd.measured metric to spans that are "internal" to the host service.

@delner delner added core Involves Datadog core libraries integrations Involves tracing integrations feature Involves a product feature labels Mar 17, 2020
@delner delner requested review from marcotc, brettlangdon and a team March 17, 2020 00:55
@delner delner self-assigned this Mar 17, 2020
@delner
Copy link
Contributor Author

delner commented Mar 17, 2020

Just as a note, this implements it for all integrations except GraphQL which is managed in the GraphQL repo. We'll need to update this behavior in a separate PR for that repo.

marcotc
marcotc reviewed Mar 17, 2020
View reviewed changes
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look very good, I really like how clean the reusable test assertion turned out.

I left a few comments with minor suggestions.

docker-compose.yml Show resolved Hide resolved
lib/ddtrace/analytics.rb Outdated Show resolved Hide resolved
brettlangdon
brettlangdon reviewed Mar 17, 2020
View reviewed changes
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few minor questions, mostly around whether we should be computing metrics for template rendering, but otherwise, lgtm

lib/ddtrace/contrib/action_view/events/render_partial.rb Show resolved Hide resolved
lib/ddtrace/contrib/action_view/events/render_template.rb Show resolved Hide resolved
lib/ddtrace/contrib/action_view/instrumentation/partial_renderer.rb Show resolved Hide resolved
lib/ddtrace/contrib/sinatra/tracer.rb Show resolved Hide resolved
@delner delner merged commit c0d9be7 into master Mar 18, 2020
@delner delner deleted the feature/add_measured_tag branch March 18, 2020 19:51
@delner delner added this to the 0.34.0 milestone Mar 30, 2020
@delner delner added this to Merged & awaiting release in Active work Mar 30, 2020
@delner delner moved this from Merged & awaiting release to Released in Active work Mar 31, 2020
@marcotc marcotc mentioned this pull request Apr 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcotc marcotc marcotc approved these changes

@brettlangdon brettlangdon brettlangdon approved these changes

Assignees

@delner delner

Labels
core Involves Datadog core libraries feature Involves a product feature integrations Involves tracing integrations
Projects
Active work
  
Released
Milestone
0.34.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delner @marcotc @brettlangdon