Add DD_VERSION environment variable #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
core
delner
commented
Mar 20, 2020
| str | ||
| end | ||
| end.freeze | ||
|
|
||
| NULL_IDENTIFIER = Identifier.new.freeze |
There was a problem hiding this comment.
Because the env property of Identifier was being resolved at initialization time, this constant would resolve its env property to nil at load time (if DD_ENV wasn't set) and retain this value. Later, if users configured a different env within the Ruby application, this instance would not use the updated value as expected, but the original value.
marcotc
previously approved these changes
Mar 23, 2020
| # or buffered by a whitespace character to delimit it. | ||
| def have_attribute(attribute) | ||
| match(/.*(?<=\A|\s)#{Regexp.escape(attribute)}(?=\z|\s).*/) | ||
| end |
There was a problem hiding this comment.
Thanks. Just realized I accidentally left in that greedy capture .* while experimenting with Regexp... needed to remove this.
delner
force-pushed
the
feature/add_version_env_var
branch
from
bc6e5fe
to
5ebb6af
Compare
marcotc
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier to tag traces with the application version, this pull request defines
DD_VERSIONwhich users can set, which will automatically:This pull request also:
service.versiontag toversionaccordingly