Add DD_SERVICE environment variable #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
core
|
This pull request is based on changes from #982; it should be rebased on |
marcotc
previously approved these changes
Mar 23, 2020
delner
force-pushed
the
feature/add_service_env_var
branch
from
80bd6b8
to
bd913e6
Compare
delner
force-pushed
the
feature/add_service_env_var
branch
from
bd913e6
to
418ce9c
Compare
marcotc
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier to tag traces with the application version, this pull request defines
DD_SERVICEwhich users can set, which will act as the default service for spans if a service isn't explicitly provided for that span.Additionally it also adds conversion of OpenTelemetry's
service.nametag to theserviceattribute onDatadog::Span.In its current implementation,
DD_SERVICEwill only affect manual instrumentation that does not provide aservice, as most integrations automatically have their own default service name defined. Integration behavior will be adjusted to use this default where appropriate in another pull request.