Add runtime metrics worker #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
core
delner
commented
Mar 31, 2020
|
|
||
| self.enabled = options.fetch( | ||
| :enabled, | ||
| Datadog::Environment.env_to_bool(Ext::Runtime::Metrics::ENV_ENABLED, false) |
There was a problem hiding this comment.
Eventually want this to be driven by the configuration settings entirely (by passing it in via options) and remove the reference to the environment variable. This is a short-term behavior while we re-work configuration settings a bit.
delner
commented
Mar 31, 2020
| @metrics = options.fetch(:metrics, Runtime::Metrics.new) | ||
|
|
||
| # Workers::Async::Thread settings | ||
| self.fork_policy = options.fetch(:fork_policy, Workers::Async::Thread::FORK_POLICY_STOP) |
There was a problem hiding this comment.
We don't want forks to collect runtime metrics by default; this policy prevents the runtime metrics worker from restarting and collecting metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #879
This pull request introduces the
Datadog::Workers::RuntimeMetricsworker, which is responsible for collecting and submitting runtime metrics via Statsd. The pull request effectively extracts this runtime metrics behavior from theAsyncTransportwhich runtime metrics had previously hitchhiked on; it now separates it into its own thread and component, by using the same base as theAsyncTraceWriter.It is the complement to
AsyncTraceWriterin the respect that the combination of the two replace the responsibilities ofDatadog::Writer; we will use this component when we also transition to the newTraceWriterby default.