Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active_job support for Resque #991

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

stefanahman
Copy link
Contributor

No description provided.

@stefanahman stefanahman requested a review from a team April 2, 2020 09:28
lib/ddtrace/contrib/resque/resque_job.rb Outdated Show resolved Hide resolved
@delner
Copy link
Contributor

delner commented Apr 2, 2020

This looks to be a duplicate of #946 by @psycholein but because this doesn't have a merge conflict, I would opt to keep this one instead.

Also need to add specs to test this change before its merge ready.

@delner delner added community Was opened by a community member feature Involves a product feature integrations Involves tracing integrations labels Apr 2, 2020
Copy link
Contributor

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the contribution! 🎉

@delner delner merged commit 5145ebe into DataDog:master Apr 15, 2020
@delner delner added this to the 0.35.0 milestone Apr 16, 2020
@stefanahman stefanahman deleted the resque-active-job branch April 17, 2020 09:12
@stefanahman stefanahman restored the resque-active-job branch April 17, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Was opened by a community member feature Involves a product feature integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants