Add JRuby 9.2 to CI #995
Merged
Add JRuby 9.2 to CI #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
added
core
delner
approved these changes
Apr 15, 2020
| @@ -51,8 +51,11 @@ Gem::Specification.new do |spec| | |||
| spec.add_development_dependency 'yard', '~> 0.9' | |||
| spec.add_development_dependency 'webmock', '~> 2.0' | |||
| spec.add_development_dependency 'builder' | |||
| spec.add_development_dependency 'ruby-prof' | |||
| spec.add_development_dependency 'sqlite3', '~> 1.3.6' | |||
| if RUBY_PLATFORM != 'java' | |||
There was a problem hiding this comment.
Not something we have to address here, but we should consider moving these "development dependencies" entirely out of the gemspec to the Gemfile, as they drive our test suite mostly. (A change that would be analogous to what we did for pry-nav.)
There was a problem hiding this comment.
Sounds like a nice way to clean up the gemspec file 👍
| @@ -55,6 +55,8 @@ def flush | |||
| def gc_metrics | |||
| Hash[ | |||
| GC.stat.map do |k, v| | |||
| next if v.is_a?(Hash) # TODO: JRuby supports additional nested metrics | |||
There was a problem hiding this comment.
Will be interesting to expand on this later.
| @@ -0,0 +1,15 @@ | |||
| module PlatformHelpers | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for running the tracer tests against JRuby.
Currently, we only run tracer core tests: integrations are not tested.