Strip Windows carriage returns "\r" in EscapeContent() #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 any c# dev will most likely use AppendLine, or WriteLine, or Environment.NewLine everywhere in the strings he builds, and that will fill the strings with /r. I had to go around this in my code, it would be better to have the provided library taking care of it. |
|
Looks good to me, thanks @anthonychu @orsobrown |
remh
added a commit
that referenced
this pull request
Jul 17, 2015
Strip Windows carriage returns "\r" in EscapeContent()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are carriage returns
\rin an event's text, the portion after the first\rdoes not make it into DataDog's event feed.For example, an exception's stack trace contains
\r\nat the end of every line. Stripping the character when escaping content seems like a reasonable thing to do.