Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstractions #30

Closed
wants to merge 2 commits into from
Closed

Abstractions #30

wants to merge 2 commits into from

Conversation

nrjohnstone
Copy link
Contributor

We are using DataDog and the lack of an abstraction over the static DogStatsd is an impedance in our TDD and test coverage.

Refactoring to provide an interface IDogStatsd and an instance based DogStatsdService for those people using TDD.

Also still provides the ability to register the instance with your IoC container as a singleton if we want to retain the current "static" functionality

… containers to manage singletons

refactor static DogStatsd to use static instance of service class to maintain current functionality
@nrjohnstone
Copy link
Contributor Author

Can this be reviewed at some point? It would be nice to be able to plan on retiring our internal abstractions and just rely on the DataDog nuget package providing them

@yannmh
Copy link
Member

yannmh commented Jul 21, 2016

Hello @nrjohnstone,

Thanks a lot for your contribution. I apologize for the delay in responding to you.
We are planning a new release for the end of next week: I'll take a pass at it by that date, so it can go out with it 🚢 :)

@yannmh yannmh added this to the 2.2.0 milestone Jul 21, 2016
@nrjohnstone
Copy link
Contributor Author

@yannmh are you able to give an eta of when 2.2.0 will be cut? We are in need of the "check" API methods that have been added to enable better reporting of the internal application state and I don't want to have to build our own internal version if you guys are releasing soon

@yannmh
Copy link
Member

yannmh commented Jul 26, 2016

@nrjohnstone Yes, we are planning a new release Friday, later Monday, August 1st.

@nrjohnstone
Copy link
Contributor Author

@yannmh any update on getting this merged and when 2.2.0 is coming?

@nrjohnstone
Copy link
Contributor Author

@yannmh can I get an update on the release date for 2.2.0

@yannmh yannmh modified the milestones: 2.2.0, Triage Oct 13, 2016
@nrjohnstone
Copy link
Contributor Author

nrjohnstone commented Oct 28, 2016

wtf? I opened this on July.. we have been using our own abstractions internally while waiting for this to get merged and release... are you going to use it or not ?

@yannmh yannmh mentioned this pull request Oct 28, 2016
@yannmh
Copy link
Member

yannmh commented Oct 28, 2016

I apologize for the delay on this @nrjohnstone !

The transition to .NET Core took most of our time, and lead us to drop the initial relae roadmap. I moved the card back in Triage two weeks ago, while I was drawing out a new roadmap and release plan.

We are planning a new major release today, and this will be included. I have rebased your changed and opened a new PR: #40 . You will be credited in the changelog and release notes.

@yannmh yannmh closed this Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants