Upgrade to use .NET Core 2.0 SDK. Fixed AppVeyor build. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 24, 2017 09:26
…upported so replaced it with Moq. Currently targeted frameworks: - netstandard1.3 - netstandard1.6 - netcoreapp1.1 - netcoreapp2.0 - net451 - net461
Closed
|
Thanks a lot @pdpurcell 🙇 , this is a great upgrade! We also appreciate the effort you put into cleaning up the code base (it's been a while since we had to move out of I'll make a separate PR to attempt to solve the NuGet versioning in AppVeyor, and list the new targeted frameworks to the repository README. We'll be releasing a new package this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AppVeyor build wasn't working because it seemed to be using the wrong SDK version. I've updated the projects so that they use the .NET Core 2.0 SDK. The build now works on AppVeyor and VS2017.
This change allowed an update of the targeted frameworks, so the client now supports:
Additionally, Rhino Mocks was no longer supported by all the frameworks (as well as not being a maintained project for many years) so I've updated the unit tests to now use Moq.
If this pull request is accepted, then I will create some additional requests to fix issues: #42, #43 and #49 .