Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No default value for tags on StatsdClient.DogStatsd.Decrement #61

Closed
sqdk opened this issue Nov 22, 2017 · 2 comments
Closed

No default value for tags on StatsdClient.DogStatsd.Decrement #61

sqdk opened this issue Nov 22, 2017 · 2 comments

Comments

@sqdk
Copy link

sqdk commented Nov 22, 2017

I was wrapping this library in F# and found out that the tags parameter for Decrement doesn't have a default value of null like all the others.

Not sure what the consequences of this change is or if it is actually intended behaviour.
@sqdk
Copy link
Author

sqdk commented Nov 22, 2017

PR #60 solves this

@sqdk
Copy link
Author

sqdk commented Nov 22, 2017

I can confirm that i get the expected behaviour of only 1 required parameter on .NET Core 2.0.

@sqdk sqdk mentioned this issue Dec 12, 2017
Merged
@sqdk sqdk closed this as completed Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sqdk