Add service checks #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wang-arthur
commented
Mar 2, 2015
wang-arthur
commented
- Service checks are supported by the agent's dogstatsd server starting in version 5.2.
- Also fixes a couple bugs in event formatting
| tags = opts[:tags] | ||
| tags.each do |tag| | ||
| rm_pipes tag | ||
| end |
There was a problem hiding this comment.
.each doesn't modify the array in-place here.
There was a problem hiding this comment.
I've rebased, so rm_pipes is now in-place
|
Otherwise LGTM! |
|
@wang-arthur looks like it can't be merged, can you have a look please ? |
|
Ah! will take a look -- forgot about this one |
added 3 commits
May 19, 2015 15:30
- Also, fix a few typos Conflicts: lib/statsd.rb
wang-arthur
force-pushed
the
add_service_checks
branch
from
9140063
to
e1d23c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.