Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding telemetry to the dogstatsd client #128

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Adding telemetry to the dogstatsd client #128

merged 1 commit into from
Jan 16, 2020

Conversation

hush-hush
Copy link
Member

Having client side telemetry is very helpful in troubleshooting packet drop between the client and the datadog-agent.

@hush-hush hush-hush added the WIP label Jan 9, 2020
@hush-hush hush-hush removed the WIP label Jan 13, 2020
@hush-hush hush-hush mentioned this pull request Jan 13, 2020
Merged
kbogtob
kbogtob reviewed Jan 14, 2020
View reviewed changes
Copy link
Contributor

@kbogtob kbogtob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. I'm not a huge fan of having multiple classes by file, it's not really rubyesque. Same problem for tests, but it's more a project issue.

lib/datadog/statsd.rb Outdated Show resolved Hide resolved
lib/datadog/statsd.rb Outdated Show resolved Hide resolved
lib/datadog/statsd.rb Outdated Show resolved Hide resolved
lib/datadog/statsd.rb Outdated Show resolved Hide resolved
lib/datadog/statsd.rb Outdated Show resolved Hide resolved
spec/helper.rb Outdated Show resolved Hide resolved
spec/helper.rb Outdated Show resolved Hide resolved
spec/helper.rb Outdated Show resolved Hide resolved
spec/helper.rb Outdated Show resolved Hide resolved
spec/statsd_spec.rb Outdated Show resolved Hide resolved
kbogtob
kbogtob approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@kbogtob kbogtob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

remeh
remeh approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@remeh remeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a Ruby expert neither but looks pretty great to me! I've just left some questions.

lib/datadog/statsd.rb Show resolved Hide resolved
lib/datadog/statsd.rb Show resolved Hide resolved
@hush-hush hush-hush merged commit c56a756 into master Jan 16, 2020
@hush-hush hush-hush deleted the maxime/statsd-telemetry branch January 16, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remeh remeh remeh approved these changes

@kbogtob kbogtob kbogtob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hush-hush @remeh @kbogtob