time stat on failing block #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…raising the error so that it does not change anything in the rest of the processing
|
Looks like I need to fix the tests with jruby surprisingly not measuring the same time difference |
gleseur
force-pushed
the
sending_time_on_failing_block
branch
from
f727993
to
fd2e8ad
Compare
|
ok now but the i18n gem issue |
|
Great enhancement ! Thanks a lot for your contribution @gleseur. I am merging your changes so we can release a new gem. About the Travis CI build failing, we are dropping Ruby1.8 support so it should not be an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The goal of this PR is to still send the time stat when the monitored block is failing.
Done here: