Namespace dogstastd #32

degemer · 2016-09-20T20:18:56Z

Rebase of #21.

yannmh

Looks good 🍥

Let's detail/highlight the CHANGELOG before this get released.

yannmh · 2016-09-20T22:33:15Z

CHANGELOG.md

+
+### Changes
+* [OTHER] Namespace the statsd Class under the Datadog module.
+


I believe we should make a highlight ➕ of that . [OTHER] sounds too much of a small change.

yannmh · 2016-09-20T22:41:53Z

spec/statsd_spec.rb

@@ -1,14 +1,14 @@
 require 'helper'
 require 'timecop'

-describe Statsd do
-  class Statsd
+describe Datadog::Statsd do


Do we want to rename this one too? https://github.com/DataDog/dogstatsd-ruby/blob/49dd6b293a2774620a791c55fdd2f13f79186d4a/spec/statsd_spec.rb#L552

Otherwise you can't load it with any other type of statsd.

rack ~> 1.6 for Ruby < 2.2 compatibility json ~> 1.8 for Ruby 1.9.3 compatibility

degemer · 2016-09-21T15:40:33Z

Thanks for the review @yannmh ! Addressed both of your comments.

degemer added this to the 2.0.0 milestone Sep 20, 2016

yannmh approved these changes Sep 20, 2016

View reviewed changes

yannmh self-assigned this Sep 20, 2016

Christophe Verbinnen and others added 2 commits September 21, 2016 11:31

Namespace the Statsd class on the datadog module.

de4f20f

Otherwise you can't load it with any other type of statsd.

[ci] add deps reqs fo Ruby version compatibility

c47c983

rack ~> 1.6 for Ruby < 2.2 compatibility json ~> 1.8 for Ruby 1.9.3 compatibility

degemer force-pushed the quentin/namespace-dogstatsd branch from 49dd6b2 to c47c983 Compare September 21, 2016 15:31

degemer merged commit d053004 into master Sep 21, 2016

degemer deleted the quentin/namespace-dogstatsd branch September 21, 2016 15:57

degemer mentioned this pull request Sep 22, 2016

Namespace the Statsd class on the datadog module. #21

Closed

Provide feedback


		### Changes
		* [OTHER] Namespace the statsd Class under the Datadog module.