Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It’d be helpful if the docs described error handling #39

Open
aviflax opened this issue Oct 28, 2016 · 2 comments
Open

It’d be helpful if the docs described error handling #39

aviflax opened this issue Oct 28, 2016 · 2 comments

Comments

@aviflax
Copy link

aviflax commented Oct 28, 2016

There’s no mention of what happens if an attempt to emit a metric fails, for example if, I dunno, maybe if the UDP socket is closed.

If an exception might be raised, it would be helpful if it was a specific exception subclass, something like Datadog::TransmissionError, so it could be rescued and handled specifically.

@pnomolos
Copy link

@aviflax I know this is quite late, but as the code stands no error is thrown - see https://github.com/DataDog/dogstatsd-ruby/blob/master/lib/datadog/statsd.rb#L434-L440

@aviflax
Copy link
Author

aviflax commented May 15, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants