New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make logger an instance var #90

Merged

gmmeyer merged 1 commit into DataDog:master from grosser:grosser/logger

Jun 6, 2018

Contributor

grosser commented May 31, 2018

having a global logger seems kinda like an anti-pattern, so prefer instance var like everything else ?

grosser force-pushed the grosser/logger branch from a4b9380 to 8ac9277 Compare

May 31, 2018 17:07


          make logger an instance var

4e7a826

grosser force-pushed the grosser/logger branch from 8ac9277 to 4e7a826 Compare

May 31, 2018 22:47

gmmeyer approved these changes

View reviewed changes

Contributor

gmmeyer left a comment

yea this does not seem threadsafe great job!

gmmeyer merged commit 401f6b3 into DataDog:master

masci added this to the 4.0.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment