Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract batch logic into a class #95

Merged
merged 1 commit into from
Jul 12, 2018
Merged

extract batch logic into a class #95

merged 1 commit into from
Jul 12, 2018

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Jun 14, 2018

@grosser
Copy link
Contributor Author

grosser commented Jun 26, 2018

@gmmeyer

1 similar comment
@grosser
Copy link
Contributor Author

grosser commented Jul 4, 2018

@gmmeyer

@gmmeyer
Copy link
Contributor

gmmeyer commented Jul 12, 2018

Hey! Sorry for the delay on this, @grosser. I'll take a look at this now, thank you!

gmmeyer
gmmeyer approved these changes Jul 12, 2018
View reviewed changes
Copy link
Contributor

@gmmeyer gmmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! thanks a lot for your contribution @grosser

@gmmeyer gmmeyer merged commit 8a37c58 into DataDog:master Jul 12, 2018
@grosser grosser deleted the grosser/batch branch July 12, 2018 21:40
@masci masci added this to the 4.0.0 milestone Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmmeyer gmmeyer gmmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grosser @gmmeyer @masci