Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using micrometer-registry-statsd doesn't report TimeUnit to DataDog #145

Open
ayeletmorris opened this issue Apr 28, 2021 · 1 comment
Open

Comments

@ayeletmorris
Copy link

Hi, I'm using micrometer-registry-statsd with @timed to report time series data to DataDog, and all of my metrics have "none" in the time unit section in the metrics summary page.

I saw that in the StatsdMeterRegistry class the "getBaseTimeUnit" method returns Milliseconds, and when I updated all my metrics manually (this took forever :) ) to milliseconds, the data in my graphs makes sense.

Why doesn't it show this reported time unit in the dataDog metric? Why isn't is sent?

BTW - I asked this question in micrometer gitHub and got this answer: micrometer-metrics/micrometer#2528
They say that in their implementation (DatadogMeterRegistry) they do send the time unit in the metric metadata, and that the issue here is in the dogStatsD client.

Thanks for your help :)

@truthbk
Copy link
Member

truthbk commented Oct 28, 2021

@ayeletmorris I'm not sure how we can help you, micrometer-registry-statsd does not use this project, java-dogstatsd-client, internally. Perhaps I'm misunderstanding your question?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants