Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added JMX TabularData support #111

Closed
wants to merge 4 commits into from

Conversation

brothhaar
Copy link

Copied from #104, since I screwed up that branch.

Added JMX TabularData support
When a TabularData type is encountered, multiple metrics are generated with the same alias, but a unique tag per entry
The tag is generated by concatenating each of the (possibly multiple) key values for each CompositeData entry in the TabularData JMX value
Also included limit and sort capability to allow sorting and limiting the number of metrics returned for a single configuration entry (since a TabularData value could have many records).
YAML config format:

      - include:
          domain: <domain>
          bean:
            - <bean name>
          attribute:
            <TabularData attribute name>:
              metric_type: <type>
              alias: <alias>
              tags:
                <tag name>: $key
              limit: 20
              sort: desc

@brothhaar brothhaar changed the title Jmx tabular data2 Added JMX TabularData support Oct 20, 2016
@brothhaar brothhaar closed this Oct 25, 2016
@brothhaar brothhaar reopened this Oct 25, 2016
@yannmh yannmh added this to the Triage milestone Oct 26, 2016
@yannmh yannmh self-assigned this Oct 26, 2016
@yannmh
Copy link
Member

yannmh commented Oct 26, 2016

Thanks for the hard work @brothhaar ! 🙇

Your changes are quite significant. We'll do our best to review, test it and follow up as soon as possible. As we currently are in the process of releasing Datadog Agent 5.10.0, the goal is to have it out for the Datadog Agent 5.11.0 🚀 .

@brothhaar
Copy link
Author

Thanks @yannmh. I still have one test failure I'm working out, but after that it should be good to go.

@brothhaar
Copy link
Author

OK @yannmh, the transient test failure I was seeing was related to counter metric rate calculation after a bean refresh (which I added to the test). The timing changed and I was seeing rates of 0.96 - 1.0 rather than the 0.98 - 1 that the TestApp was expecting. It's not a new bug, IMO, just odd timing in the test. I updated the metric's expected range.

Sorry about the delay on this, I'm just now cleaning up my TODO list from the past few months.

@yannmh yannmh modified the milestones: 0.13.0, Triage Dec 30, 2016
@yannmh
Copy link
Member

yannmh commented Mar 1, 2017

I apologize for the late review @brothhaar.

The changes looks great! I forked your changes to add some slight modifications and opened a new PR: #128. I'd very appreciate to have your feedback on it before I merge it.

Thanks a lot again for the hard work!

@yannmh yannmh closed this Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants