Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple instances in the http_check. #155

Closed
wants to merge 1 commit into from

Conversation

jniesen
Copy link
Contributor

@jniesen jniesen commented Dec 18, 2015

Adds the instances parameter to the http_check class.

This parameter defaults to undef.

For backwards compatibility, if the instances array not defined it
will be instantiated as an array containing a single hash. The remaining
parameters of the class will be used for the key/value pairs in the
hash. This will allow us to iterate over the instances array in the
template.

Adds the ``instances`` parameter to the ``http_check`` class.

This parameter defaults to undef.

For backwards compatibility, if the ``instances`` array not defined it
will be instantiated as an array containing a single hash. The remaining
parameters of the class will be used for the key/value pairs in the
hash. This will allow us to iterate over the ``instances`` array in the
template.
@truthbk truthbk added this to the triage milestone Jan 8, 2016
@truthbk truthbk modified the milestones: 1.7.0, triage Apr 7, 2016
@truthbk
Copy link
Member

truthbk commented Apr 7, 2016

@jniesen have you run this successfully? I tried it out and get the infamous variable reassignment error (the puppet DSL won't allow that).

@truthbk
Copy link
Member

truthbk commented Apr 7, 2016

@jniesen don't worry about it, pulled your changes in and fixed what needed fixing :) Thanks again.

@jniesen
Copy link
Contributor Author

jniesen commented Apr 7, 2016

What ended up needing fixing. I'm pretty sure I ran this successfully, but
it's been a few months. I'm not sure if I did something more in my fork.

On Thu, Apr 7, 2016, 5:24 PM Jaime Fullaondo notifications@github.com
wrote:

@jniesen https://github.com/jniesen don't worry about it, pulled your
changes in and fixed what needed fixing :) Thanks again.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#155 (comment)

@truthbk
Copy link
Member

truthbk commented Apr 8, 2016

@jniesen as you know, variables don't allow for reassignment in the puppet DSL, which is something we were doing with the instances variable, but that was all.

@truthbk
Copy link
Member

truthbk commented Apr 12, 2016

Included in #176, fixed minor details there. Thanks!

@truthbk truthbk closed this Apr 12, 2016
@truthbk
Copy link
Member

truthbk commented Apr 13, 2016

@jniesen just wanted to let you know there was a typo in the changelog that shipped with the released puppet module 1.7.0 that failed to recognize your contribution, it's already been fixed in github and will be corrected in subsequent releases. My apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants