Puppet 4 support + stdlib>=4.6 fixes #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`name` is a built in parameter in puppet 4, and cannot be used. Renaming `name` to `tag_name` allows puppet 4 to correctly compile the catalog. Also set rspec-puppet to the latest tag. The master branch of rspec-puppet has some issues with the `that_comes_before` method.
…te_integer function.
This was referenced Jan 19, 2016
Closed
|
👍 on puppet |
|
👍 |
truthbk
added a commit
that referenced
this pull request
Jan 19, 2016
Puppet 4 support + stdlib>=4.6 fixes
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Jan 31, 2018
Puppet 4 support + stdlib>=4.6 fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in the changes from @grubernaut and @mrunkel-ut, this just needed minor touching-up.
Tested on Puppet 4 successfully.