add option in datadog_agent to extract hostnames #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @truthbk |
|
@LeoCavaille will merge this in for the next release I'm working on. I don't see any |
|
@truthbk boo this one is on me fixing! |
Fixes DataDog#160. This option is a string regex which can be enabled and used to extract the hostname from puppet hostname strings with a capture group. It is useful for people that have specific puppet hostnames and that would like to sanitize them before reporting those in Datadog.
LeoCavaille
force-pushed
the
leo/hostnameextract
branch
from
15f8ef9
to
830ffe8
Compare
|
@truthbk should be fixed! I added one more commit on top that is unrelated to my PR but makes the lint command works. |
|
Included in #176, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #160.
This option is a string regex which can be enabled and used to extract
the hostname from puppet hostname strings with a capture group.
It is useful for people that have specific puppet hostnames and that
would like to sanitize them before reporting those in Datadog.
cc @olivielpeau @diranged
There are unrelated
rake lintandrake specerrors that I can fix as part of another PR.