[puppet] dogstatsd should be on by default. #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha yeah, this bit us too. Would love to have it turned back on by default, as well as for backwards compatibility in 1.x. |
truthbk
force-pushed
the
jaime/fixdogstatsd
branch
from
814974f
to
ac9088d
Compare
|
Tested manually - successfully. |
|
do we still need lines 28-30 in |
truthbk
force-pushed
the
jaime/fixdogstatsd
branch
from
ac9088d
to
10172ad
Compare
|
I removed the Travis changes. Those should go into its own PR. Unfortuntely due to the issue with the |
|
👍 - LGTM |
[travis] ruby 1.9.3 has been EOL'd for a while, adding 2.2.3 and fixing CI. [travis] newer rubies got issues with the puppet (official) gems. [travis] fixing spec tests - default for dogstatsd is yes. [travis] pinpoint rubocop to 0.35.x to address ruby 2.2.3 testing issues. [travis] syck required? [travis] excluding incompatible puppet modules with ruby 2.2.3. [travis] moving changes to its own PR.
truthbk
force-pushed
the
jaime/fixdogstatsd
branch
from
10172ad
to
7ceb7b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.