Add supervisord integration config files #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @truthbk is there any problem with the PR? we need it to continue working with DataDog. |
|
@cristianjuve @marcgascon there's nothing wrong with the PR. Actually it looks quite good, but it's missing the spec tests. It would be great if you could add a few. Thank you so much for the contribution. |
cristianjuve
force-pushed
the
add-supervisord-integration-files
branch
from
fb2b3b1
to
d481fc7
Compare
|
Hi @truthbk, I've created spec tests :) check the spec file and if is all OK, please merge this PR :) Thk! |
|
@cristianjuve Awesome, very nice! Thank you so much! Sorry to make you do that, we're just trying to keep as much of the manifests tested as possible. Merging! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Jan 31, 2018
…gration-files Add supervisord integration config files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.