Support cassandra integration tags #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sethcleveland
commented
Oct 31, 2016
sethcleveland
commented
- Change tags to match jmx fetch's data dog -- array to hash
- Change tags to match jmx fetch's data dog -- array to hash
sethcleveland
force-pushed
the
support_cassandra_integration_tags
branch
from
e93e0ee
to
4a2e03c
Compare
|
@truthbk JMX fetch expects a hash. here's the corresponding JMX code that fails when tags is an array --https://github.com/DataDog/jmxfetch/blob/e69217c32c51afed312aa3a54e7125912c429cab/src/main/java/org/datadog/jmxfetch/Instance.java#L71. This can be address either in puppet or the jmxfetch app. This code reflects changing puppet to match JMX fetch. JMXFetch can also be changed to be an array. |
|
This looks good @sethcleveland! Thanks a bunch for the test. We'll be releasing an updated module soon. 👍 |
|
Cool, looking forward to that release! 👍 |
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Jan 31, 2018
…ntegration_tags Support cassandra integration tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.