Add support for CIRCLE_NODE_{TOTAL,INDEX} environment variables #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettlangdon
commented
Apr 29, 2021
| ci_node_index = os.environ["CIRCLE_NODE_INDEX"] | ||
|
|
||
| if ci_node_total and ci_node_index: | ||
| venvs = list(_iter_venvs()) |
There was a problem hiding this comment.
I was originally thinking we might want to do venvs = sorted(_iter_venvs()) to ensure the results are consistent, but would it be weird that the ordering of the venvs changes based on whether you use parallelism or not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47
I am not convinced having this be the default behavior is the best? Should we require a cli switch to say to use these env variables, or maybe an env variable to disable this behavior?
can we think of a case when someone would not want this? only thing I can think of is if you are using some other tooling to split tests envs that you give to riot, like https://github.com/DataDog/dd-trace-py/blob/8ded786edb6e0b3d7b2e079ae58a0d9ab87ffd05/.circleci/config.yml#L130