Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: server-oriented setup command #57

Closed
tlhunter opened this issue Sep 22, 2022 · 2 comments
Closed

Feature request: server-oriented setup command #57

tlhunter opened this issue Sep 22, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@tlhunter
Copy link
Member

I'd like to see the ability to run a setup command that doesn't need to exit before the benchmarks run. Maybe like a setup_watch or server option in the JSON configuration. Then, once the tests complete, the long running setup child is killed.

This would be useful for running servers where the server doesn't need to daemonize. I find handing these daemonized processes gets tricky. One could track pids and have a teardown command kill the pid but I bet it's a common enough use case that it's worth supporting in sirun.

If one were to benchmark redis-server then a long running server option would make for a clean interface.

Also, I'm not sure if there's a better name for all of this. An attached vs detached child?

@tlhunter tlhunter added the enhancement New feature or request label Sep 22, 2022
@bengl
Copy link
Collaborator

bengl commented Nov 4, 2022

I think this may be the same as #45?

@tlhunter
Copy link
Member Author

tlhunter commented Nov 8, 2022

It is!

@tlhunter tlhunter closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants