Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Azure attack techniques #52

Closed
christophetd opened this issue Jan 21, 2022 · 6 comments
Closed

Support Azure attack techniques #52

christophetd opened this issue Jan 21, 2022 · 6 comments

Comments

@christophetd
Copy link
Contributor

No description provided.

@rcobb-scwx
Copy link
Contributor

Hello maintainers,

Just a heads up: I am currently going through an open source approval process to open a PR related to this issue. I have a working Azure provider and two example attacks (executing a run command and executing a custom script extension on a VM). The change is straight-forward enough, but I did need to bump golang to 1.18 to align with the newer azure-sdk-for-go modules. Theoretically it can be done with 1.17, but I would need to fall back to the legacy SDK and I am not sure how long that will be supported in earnest.

Any objections to bumping golang to 1.18? Or is that a total non-starter?

Thanks!

P.S. This is a really wonderful project, thank you so much for putting it together.

@christophetd
Copy link
Contributor Author

Hello!

This sounds great and I'm looking forward to your contribution!

Could you open 1 issue for each new attack technique you'd like to contribute, so we can make sure they align with the project's philosophy?

I see no issue bumping to golang 1.18

Thanks!

@rcobb-scwx
Copy link
Contributor

Hi @christophetd -- I got approval today to open up the PR. Would you like me to separate the Azure provider and each Azure attack technique into3 separate PRs? Or would you like me to open one PR with the provider and one attack, and then another PR with the second attack? Whatever is easiest for you.

If you want a preview of the provider and the two attacks, you can see the diff view here: https://github.com/DataDog/stratus-red-team/compare/main...rcobb-scwx:main?diff=split#

This is my first foray into Golang development, so please be gentle :)

Thanks again!

@christophetd
Copy link
Contributor Author

This is amazing! I'd suggest (if it's not too much work for you):

  • 1 PR with the Azure provider alone targeting main
  • 1 PR for each attack technique, each targeting the branch where you have the Azure provider

Excited about the contribution!

@rcobb-scwx
Copy link
Contributor

Awesome, so glad to hear.

Yep, 3 PRs is fine with me. I'll open them up over the next few days.

@rcobb-scwx rcobb-scwx mentioned this issue May 1, 2022
4 tasks
@christophetd
Copy link
Contributor Author

Now supported as part of v2.0.0, see change log! Thanks @rcobb-scwx for the awesome contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants