Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way fo force a test to be executed if a component is on a given branch #1054

Closed
cbeauchesne opened this issue Apr 6, 2023 · 3 comments
Labels
dev-x Improve developer experience

Comments

@cbeauchesne
Copy link
Collaborator

cbeauchesne commented Apr 6, 2023

The idea is to solve the egg-chicken issue when somebody want to add a feature/fix in a component, and activate the test.

@branch(ruby="add-remote-config-or-whatever")
  1. We get the repo name and the branch name threw env var (probably the simplest)
  2. if the repo name and the branch name matches a @branch declaration, any @released, @bug declaration are ignored, and the test is executed

It will be used on distant repos, and totally ignored in nightly runs.

@cbeauchesne
Copy link
Collaborator Author

and unfortunately, it solves nothing, as we need to do a Pr on system tests after distant PR is merged :(

@cbeauchesne
Copy link
Collaborator Author

Implem idea :

  • mount binaries folder inside runner container
  • install git tools in runner container
  • in runner, if /binaries/repo-name exists, get data from it

it'll saves any requirements from weblog container

@cbeauchesne cbeauchesne added the dev-x Improve developer experience label Apr 11, 2023
@cbeauchesne cbeauchesne changed the title @branch decorator Add a way fo force a test to be executed if a component is on a given branch Apr 11, 2023
@cbeauchesne
Copy link
Collaborator Author

won't do, in favor of #913 : it's too complicated, solving nothing.

#913 offer a gentle way to declare some arbitraries test to run.

A PR on system tests remain mandatories, version declarations remains the main way to activate tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-x Improve developer experience
Projects
None yet
Development

No branches or pull requests

1 participant