-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make system tests works on forks ? #975
Comments
idea 1 : distant repo has a valid DD_API_KEY in secrets |
Some context of why this would be useful: System tests always fail on forks. This means that we can never know if an external PR breaks something until it's merged. It also means that we cannot require system tests to pass in order to merge, otherwise it blocks merging forks completely. |
So, I just learned that a button Approve and run exists :) https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks |
@cbeauchesne The button exists, and it does appear in PRs, but clicking it only results in system tests running and always failing because it cannot access the API key. |
ouch ... |
This is also true for CircleCI. Would it be possible to split up running the tests and reporting the results? I know this might not work well with end to end tests, but at least it would be something. |
idea 3 : mocked backend it will work for almost all scenario, as we don't test responses from backend. And will be able to use a fake key. |
No description provided.
The text was updated successfully, but these errors were encountered: