Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make system tests works on forks ? #975

Open
cbeauchesne opened this issue Mar 16, 2023 · 7 comments
Open

Make system tests works on forks ? #975

cbeauchesne opened this issue Mar 16, 2023 · 7 comments
Assignees
Labels
dev-x Improve developer experience

Comments

@cbeauchesne
Copy link
Collaborator

No description provided.

@cbeauchesne
Copy link
Collaborator Author

idea 1 : distant repo has a valid DD_API_KEY in secrets
idea 2: system test repos hosts the process

@rochdev
Copy link
Member

rochdev commented Mar 16, 2023

Some context of why this would be useful:

System tests always fail on forks. This means that we can never know if an external PR breaks something until it's merged. It also means that we cannot require system tests to pass in order to merge, otherwise it blocks merging forks completely.

@cbeauchesne
Copy link
Collaborator Author

So, I just learned that a button Approve and run exists :)

https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

@cbeauchesne cbeauchesne self-assigned this Mar 17, 2023
@rochdev
Copy link
Member

rochdev commented Mar 17, 2023

@cbeauchesne The button exists, and it does appear in PRs, but clicking it only results in system tests running and always failing because it cannot access the API key.

@rochdev rochdev reopened this Mar 17, 2023
@cbeauchesne
Copy link
Collaborator Author

ouch ...

@bantonsson
Copy link
Contributor

This is also true for CircleCI. Would it be possible to split up running the tests and reporting the results? I know this might not work well with end to end tests, but at least it would be something.

@cbeauchesne cbeauchesne added the dev-x Improve developer experience label Apr 11, 2023
@cbeauchesne cbeauchesne changed the title Is there a way to make system tests works on forks ? Make system tests works on forks ? Apr 11, 2023
@cbeauchesne
Copy link
Collaborator Author

idea 3 : mocked backend

it will work for almost all scenario, as we don't test responses from backend. And will be able to use a fake key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-x Improve developer experience
Projects
None yet
Development

No branches or pull requests

3 participants