Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codesandbox raises typeerror fullscreen error #28

Closed
DataGridXL opened this issue Feb 21, 2022 · 1 comment
Closed

Codesandbox raises typeerror fullscreen error #28

DataGridXL opened this issue Feb 21, 2022 · 1 comment

Comments

@DataGridXL
Copy link
Owner

DataGridXL commented Feb 21, 2022 •
edited

According to this Stackoverflow thread, it's because of document.fullscreenEnabled. It seems that in Codesandbox, the iframe document has fullscreenEnabled set to false.

image
@DataGridXL
Copy link
Owner Author

Wontfix for v2. In v3, let's make the "Fullscreen button" part check for document.fullscreenEnabled. If not enabled, disable this Fullscreen button and its function.

@DataGridXL DataGridXL closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DataGridXL