Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use One File for Each Herb in Flora #14

Closed
1 of 2 tasks
emptymalei opened this issue Aug 8, 2021 · 0 comments · Fixed by #15
Closed
1 of 2 tasks

Use One File for Each Herb in Flora #14

emptymalei opened this issue Aug 8, 2021 · 0 comments · Fixed by #15
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@emptymalei
Copy link
Member

emptymalei commented Aug 8, 2021

Is it better to have one file for each herb in flora?

Situition

Currently, the flora is defined in a single json file.

  • It becomes hard to read. This is not fitting into the human-readable principle.
  • It becomes hard to manage. We are currently sorting everything in the big file. When we have a problem, the whole flora will be unusable.

Solution

Use separate files for herbs.

Simply Copy dataherb.json

  • Copy dataherb.json to workdir/{id}/dataherb.json or {id}.json will work.

    • Using folders allows us to put in more files. For example, we can take datapackage content out to make it more managable.
  • Build the flora from all these files.

  • Implement this new structure.

Ready for a Demo repo of flora

In this way, we can put up a repo for open datasets easily and allow users to add more easily.

Possible creating process

  • Create package directly on GitHub by uploading the dataherb.json file.

    • But there should be a validation process to avoid duplicate id.
  • Setup a demo repo as demo flora.

@emptymalei emptymalei added the enhancement New feature or request label Aug 8, 2021
@emptymalei emptymalei self-assigned this Aug 8, 2021
@emptymalei emptymalei added this to the Release Beta milestone Aug 8, 2021
@emptymalei emptymalei linked a pull request Aug 12, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant