Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Journey Dag endpoints accepts duplicate edges #4

Open
aarthy-dk opened this issue Apr 20, 2024 · 0 comments
Open

API: Journey Dag endpoints accepts duplicate edges #4

aarthy-dk opened this issue Apr 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@aarthy-dk
Copy link
Contributor

Steps to reproduce

  • Send a request to PUT /observability/v1/journeys/:journey_id/dag like this: {"right": "<some_component_id>"}. 201 response is returned as expected.
  • Send the request again. Another 201 is returned, and a duplicate single-node edge is created in the database.

Expected behavior

The second call should have returned 409.

Note: The behavior works correctly in the case of 2-node edges, e.g., {"right": "<some_component_id>", "left": "<other_component_id>"}.

Impact

Users creating journeys through the API may inadvertently create duplicated data on the system. The DAG display in the UI does not seem to be affected.

@aarthy-dk aarthy-dk added the bug Something isn't working label Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant